[Tarantool-patches] [PATCH 0/2] sql: revoke table privileges on drop

[Chris Sosnin]

Hi! Thank you for the review and for your fixes!

> +box.schema.user.drop('test_user1')
> +---
> +...
> +box.schema.user.drop('test_user2')
> +---
> +...
> +box.space._sequence:select{}
> +---
> +- []
> +...

I moved sequence tests to the second commit, firstly, because here you
don't do seq:drop() (I believe because after my initial patch sequences
are getting deleted anyways, but after yours seq remains in _sequence
space) and, secondly, because this way we can better isolate these two patches
from each other.

I agree with the rest, especially with your catch about sequences.
Thus, I'm sending this patchset to Nikita.

branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4546-sql-drop-grants
issue: https://github.com/tarantool/tarantool/issues/4546

Chris Sosnin (2):
  sql: remove grants associated with the table
  sql: drop only generated sequence in DROP TABLE

 src/box/sql/build.c                       | 81 +++++++++++++++++++----
 src/box/user.cc                           |  7 ++
 src/box/user.h                            |  4 ++
 test/sql/autoincrement.result             | 80 ++++++++++++++++++++++
 test/sql/autoincrement.test.lua           | 33 +++++++++
 test/sql/gh-4546-sql-drop-grants.result   | 54 +++++++++++++++
 test/sql/gh-4546-sql-drop-grants.test.lua | 24 +++++++
 7 files changed, 269 insertions(+), 14 deletions(-)
 create mode 100644 test/sql/autoincrement.result
 create mode 100644 test/sql/autoincrement.test.lua
 create mode 100644 test/sql/gh-4546-sql-drop-grants.result
 create mode 100644 test/sql/gh-4546-sql-drop-grants.test.lua

-- 
2.21.0 (Apple Git-122.2)