[Tarantool-patches] [PATCH v2 05/16] sql: move sql_finalize() to execute.h

Nikita Pettik korablev at tarantool.org
Fri Dec 13 16:49:46 MSK 2019


On 03 Dec 23:51, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> On 20/11/2019 22:28, Nikita Pettik wrote:
> > We are going to make prepared statement cache be session local. Hence,
> 
> Session local? I thought we've decided to use a global
> cache.

Fixed commit message:

Author: Nikita Pettik <korablev at tarantool.org>
Date:   Wed Oct 23 00:04:20 2019 +0300

    sql: move sql_finalize() to execute.h
    
    We are going to introduce prepared statement cache. On statement's
    deallocation we should release all resources which is done by
    sql_finalize(). Now it is declared in sql/sqlInt.h header, which
    accumulates almost all SQL related functions. To avoid including such a
    huge header to use single function, let's move its signature to
    box/execute.h
    
    Need for #2592
 
> > when sessions is destroyed we should erase its cache and deallocate each
> > prepared statement in it. As a consequence, we should be able to call
> > sql_finalize() from box/ submodule. So let's move its signature to
> > box/execute.h
> > 
> >  Need for #2592


More information about the Tarantool-patches mailing list