[Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto
Igor Munkin
imun at tarantool.org
Fri Dec 13 16:35:14 MSK 2019
Vlad,
On 13.12.19, Vladislav Shpilevoy wrote:
> Thanks for the review!
>
<snipped>
>
> >
> >> /* reset pending wakeups */
> >> rlist_del(&fiber->state);
> >> if (! (fiber->flags & FIBER_IS_JOINABLE))
> >> diff --git a/src/lib/core/fiber.h b/src/lib/core/fiber.h
> >> index c5b975513..21fff8f88 100644
> >> --- a/src/lib/core/fiber.h
> >> +++ b/src/lib/core/fiber.h
> >> @@ -458,8 +458,17 @@ struct fiber {
> >>
> >> /** Triggers invoked before this fiber yields. Must not throw. */
> >> struct rlist on_yield;
> >> - /** Triggers invoked before this fiber stops. Must not throw. */
> >> - struct rlist on_stop;
> >> + /**
> >> + * Triggers invoked before this fiber is
> >> + * stopped/reset/recycled/destroyed/reused. In other
> >> + * words, each time when the fiber has finished execution
> >> + * of a request.
> >> + * In particular, for fibers not from fiber pool the
> >> + * cleanup is done before destroy and death.
> >> + * Pooled fibers are cleaned up after each request, even
> >> + * if they are never destroyed.
> >> + */
> >> + struct rlist on_cleanup;
> >
> > Minor: both trigger lists above has the "Must not throw" note. Does the
> > introduced list respect this rule? Please, adjust the comment if yes.
>
> Nope. These 'must not throw' are outdated. Our triggers does not
> throw errors anymore by design. So I deleted it from the updated
> comment.
>
OK, thanks, now it's clear. Guess we need an activity to update comments
for other trigger lists.
--
Best regards,
IM
More information about the Tarantool-patches
mailing list