[Tarantool-patches] [PATCH v2 03/16] sql: move sql_prepare() declaration to box/execute.h

Nikita Pettik korablev at tarantool.org
Thu Dec 5 16:32:43 MSK 2019


On 04 Dec 14:37, Konstantin Osipov wrote:
> * Nikita Pettik <korablev at tarantool.org> [19/11/21 10:00]:
> > index 16507b334..e3a2c77ca 100644
> > --- a/src/box/sql/legacy.c
> > +++ b/src/box/sql/legacy.c
> > @@ -37,6 +37,7 @@
> >   */
> >  
> >  #include "sqlInt.h"
> > +#include "box/execute.h"
> >  #include "box/session.h"
> 
> looks like a stray change?

No, it's not. Without it compilation fails:

/Users/n.pettik/tarantool/src/box/sql/legacy.c:73:8: error: implicit declaration of function 'sql_prepare' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                rc = sql_prepare(zSql, -1, &pStmt, &zLeftover);
                     ^
/Users/n.pettik/tarantool/src/box/sql/legacy.c:73:8: note: did you mean 'sqlReprepare'?
/Users/n.pettik/tarantool/src/box/sql/sqlInt.h:4181:5: note: 'sqlReprepare' declared here
int sqlReprepare(Vdbe *);
    ^

Declaration of sql_prepare() is moved to box/execute.h, so to
use it in sql/legacy.c we should include box/execute.h
 
> 
> -- 
> Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list