[Tarantool-patches] [PATCH v2] fio/coio: Handle partial writes

[Cyrill Gorcunov]

On Wed, Dec 04, 2019 at 02:34:47PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [19/12/04 14:21]:
> > +static inline int
> > +write_should_retry(void)
> > +{
> > +	/* Retry on O_NONBLOCK */
> > +	if (errno == EAGAIN)
> > +		return true;
> 
> Usually you add EWOULDBLOCK here too.

True. It somehow escaped from the drafts while I've been
merging the series of fixes. Thanks!

> > +	/* Retry if been interrupted */
> > +	if (errno == EINTR)
> > +		return true;
> 
> Not sure you should handle this. It's up to the client whether to
> make or not a write interruptible, it is managed by fcntl. 
> Otherwise you may block indefinitely inside a syscall.

OK, thanks, will drop.