[tarantool-patches] Re: [PATCH v4 1/4] sql: rename sql_vdbe_mem_alloc_region helper

[n.pettik]

> On 21 Aug 2019, at 18:28, Kirill Shcherbatov <kshcherbatov at tarantool.org> wrote:
> 
> Changed sql_vdbe_mem_alloc_region routine name to the
> sql_vdbe_mem_alloc_blob_region because we are going to introduce
> a new function with a really similar (but more appropriate) name
> vdbemem_alloc_on_region in following patch.
> 
> Needed for #2200, #4113, #2233
> ---
> src/box/sql/vdbe.h    | 2 +-
> src/box/sql/vdbe.c    | 2 +-
> src/box/sql/vdbeaux.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/box/sql/vdbe.h b/src/box/sql/vdbe.h
> index 8f16202ba..e5a85fe0e 100644
> --- a/src/box/sql/vdbe.h
> +++ b/src/box/sql/vdbe.h
> @@ -278,7 +278,7 @@ int sqlVdbeRecordCompare(struct sql *db, int key_count,
> 			     const void *key1, UnpackedRecord *key2);
> UnpackedRecord *sqlVdbeAllocUnpackedRecord(struct sql *,
> 					       struct key_def *);
> -int sql_vdbe_mem_alloc_region(Mem *, uint32_t);
> +int sql_vdbe_mem_alloc_blob_region(Mem *, uint32_t);

You can also remove ’sql’ prefix (vdbe_ prefix implies that
namespace is related to sql) and make it static.