[tarantool-patches] Re: [PATCH v2 6/7] space: get rid of apply_initial_join_row method

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/08/19 19:57]:
> There's no reason to use a special method instead of the generic
> space_execute_dml for applying rows received from a master during the
> initial join stage. Moreover, using the special method results in not
> running space.before_replace trigger, which makes it impossible to, for
> example, update space engine on a replica, see the on_schema_init test
> of the replication test suite.
> 
> So this patch removes the special method altogether and makes the code
> that used it switch to space_execute_dml.
> 
> Closes #4417

LGTM

-- 
Konstantin Osipov, Moscow, Russia