[tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS
Kirill Yukhin
kyukhin at tarantool.org
Wed Aug 28 02:54:12 MSK 2019
Hello,
On 19 авг 11:28, Max Melentiev wrote:
> To make it possible to develop and test related features on macOS.
>
> SOCK_CLOEXEC (not available on macOS) flag for socket()
> is replaced with `fcntl(fd, F_SETFD, FD_CLOEXEC)` which has the same effect.
>
> MSG_NOSIGNAL flag for sendmsg is also not available on macOS.
> However it has SO_NOSIGPIPE flag for setsockopt which disables SIGPIPE.
> So it requires different solution for different OS.
> Inspired by https://nwat.xyz/blog/2014/01/16/porting-msg_more-and-msg_nosigpipe-to-osx/
>
> `sendmsg()` is replaced with `sendto()` because `msg_namelen` was calculated incorrectly.
> New method builds message automatically without errors.
I've checked your patch into 2.2 and master.
--
Regards, Kirill Yukhin
More information about the Tarantool-patches
mailing list