[tarantool-patches] Re: [tarantool-patches] Re: [PATCH v1] gitlab-ci: clean up .gitlab-ci.yml

[Alexander Tikhonov]

>Пятница, 23 августа 2019, 14:54 +03:00 от Alexander Turenko <alexander.turenko at tarantool.org>:
>
>The approach is okay for me. Found two mistakes. Please, fix them,
>verify all jobs again and pass the patch to Kirill.
>
>WBR, Alexander Turenko.
>
>>  release_asan_clang8:
>> -  image: ${IMAGE_TEST_LTO}
>> -  stage: test
>> -  tags:
>> -    - docker_test
>> +  <<: *docker_test_lto_definition
>>    script:
>>      - ${GITLAB_MAKE} test_asan_debian_no_deps
>
>No -DENABLE_LTO=ON cmake flag. It seems that there was no before. 
In real the template doesn't have this variable, to avoid of the misleading in the feature renamed the template *lto* -> *clang8*.
>
>
>>  static_build:
>> -  only:
>> -    refs:
>> -      - master
>> -      - /^.*-full-ci$/
>> -  stage: test
>> -  tags:
>> -    - deploy
>> +  <<: *deploy_test_definition
>>    variables:
>>      RUN_TESTS: 'ON'
>> -  script:
>> -    - ${GITLAB_MAKE} static_build
>
>static build now runs debian packages build.
>
Thanks a lot, misspelled - fixed.

-- 
Alexander Tikhonov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20190823/c426a950/attachment.html>