[tarantool-patches] Re: [PATCH 2/3] txn: merge struct sql_txn into struct txn
Konstantin Osipov
kostja at tarantool.org
Tue Aug 13 00:55:54 MSK 2019
* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/08/10 00:01]:
> > + char *name;
>
> 8. I didn't like that name is stored by pointer - it consumes more
> memory, and is slower. So I changed to name[1] with variable length
> tail. But is it an advisory fix, you can skip it if you think it
> complicates the code too much. See below and on the branch.
Vlad, please, stop this optimization craziness, come on, how big
of a deal is it to allocate a name once you already parsed the
statement to create this savepoint?
--
Konstantin Osipov, Moscow, Russia
More information about the Tarantool-patches
mailing list