[tarantool-patches] Re: [PATCH] sql: remove unused mask

[Vladislav Shpilevoy]

LGTM.

On 14/08/2019 16:35, Roman Khabibov wrote:
> Vlad, could you do a second review?
> 
>> On Aug 9, 2019, at 18:46, n.pettik <korablev at tarantool.org> wrote:
>>
>>
>>
>>> On 2 Aug 2019, at 15:46, Roman Khabibov <roman.habibov at tarantool.org> wrote:
>>>
>>> Field mask of "struct Keyword" is always set to one not null
>>> macroses and used only once for checking that it isn't null. So,
>>> the field should be removed.
>>>
>>> Closes #4155
>>
>> I’ve fixed commit message and force pushed.
>>
>>    sql: remove mask from struct Keyword
>>
>>    Originally, mask in struct Keyword served to reduce set of reserved
>>    keywords for build-dependent features. For instance, it was allowed to
>>    disable triggers as a compilation option, and in this case TRIGGER
>>    wouldn't be reserved word. Nowadays, our build always comprises all
>>    features, so there's no need in this option anymore. Hence, we can
>>    remove mask alongside with related to it macros.
>>
>>    Closes #4155
>>
>> The rest is OK as obvious.