[tarantool-patches] Re: [PATCH 1/8] port: increase padding of struct port

[Vladislav Shpilevoy]

Thanks for the patch!

Currently sizeof(struct port) is 64, sizeof(struct port_sql) is 56.
It means, that one new flag port_sql fits easily. I don't think we
need that patch now.

On 27/08/2019 15:34, Nikita Pettik wrote:
> We are going to extend context of struct port_sql. One already inherits
> struct port_tuple, which makes it size barely fits into 48 bytes of
> padding of basic structure (struct port). Hence, let's increase padding
> a bit to be able to add at least one more member to struct port_sql.
> ---
>  src/lib/core/port.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/core/port.h b/src/lib/core/port.h
> index 09a026df5..abe21aa53 100644
> --- a/src/lib/core/port.h
> +++ b/src/lib/core/port.h
> @@ -113,7 +113,7 @@ struct port {
>  	 * Implementation dependent content. Needed to declare
>  	 * an abstract port instance on stack.
>  	 */
> -	char pad[48];
> +	char pad[52];
>  };
>  
>  /** Is not inlined just to be exported. */
>