[tarantool-patches] Re: [PATCH 2/8] port: move struct port_sql to box/port.h

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Aug 29 23:46:27 MSK 2019


Thanks for the patch!

On 27/08/2019 15:34, Nikita Pettik wrote:
> We are going to use port_sql_create() in box/lua/execute.c so to be able
> to call it let's make port_sql_create() non-static and move its
> declaration to box/port.h alongside with struct port_sql (since
> box/port.h already contains struct port_tuple and struct port_lua).
> 
> No functional changes are provided.

As I see, you did it to use port_sql like an in-out parameter for sql_execute.
Please, don't do this. Port is a result container. sql_execute should create
it from the scratch. If you want to pass options to sql_execute, then pass
sql_opts introduced in the last patch. port_sql_create should remain static
function of execute.c.




More information about the Tarantool-patches mailing list