[tarantool-patches] Re: [PATCH 10/13] wal: make wal_sync fail on write error

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/08/10 23:22]:
> wal_sync() simply flushes the tx<->wal request queue, it doesn't
> guarantee that all pending writes are successfully committed to disk.
> This works for now, but in order to implement replica join off the
> current read view, we need to make sure that all pending writes have
> been persisted and won't be rolled back before we can use memtx
> snapshot iterators. So this patch adds a return code to wal_sync():
> since now on it returns -1 if rollback is in progress and hence
> some in-memory changes are going to be rolled back. We will use
> this method after opening memtx snapshot iterators used for feeding
> a consistent read view a newly joined replica so as to ensure that
> changes frozen by the iterators have made it to the disk.

Please add a test case, otherwise LGTM.


-- 
Konstantin Osipov, Moscow, Russia