[tarantool-patches] Re: [PATCH v2 1/3] box: rfc for stacked diagnostic area in Tarantool

[Alexander Turenko]

On Tue, Aug 27, 2019 at 01:26:07AM +0300, Konstantin Osipov wrote:
> * Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/08/23 13:03]:
> > Part of #1148
> > ---
> >  doc/rfc/1148-stacked-diagnostics.md | 175 ++++++++++++++++++++++++++++
> >  1 file changed, 175 insertions(+)
> >  create mode 100644 doc/rfc/1148-stacked-diagnostics.md
> 
> as I mentioned before, lgtm. I agree with PeterG comments, but I
> think we can worry about them when we get to implementing SQL
> warnings.

I think the important question here is when we clear a diagnostic area
(if we ever want to decide now anything about warnings). Say, we
possibly will need to entirely split warning stacks from the error stack
and possibly will need to operate on several warning stacks.

I'm tentative that we can decide now whether we should store warnings
within the same stack as errors or not. Maybe we should postpone all
warnings questions now and concentrate on errors within the scope #1148.

WBR, Alexander Turenko.