[tarantool-patches] Re: [PATCH v4 4/4] sql: support user-defined functions in SQL

[n.pettik]

> diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> index c5d91ceee..9fb217822 100644
> --- a/src/box/sql/vdbe.c
> +++ b/src/box/sql/vdbe.c
> @@ -46,6 +46,7 @@
> #include "box/fk_constraint.h"
> #include "box/txn.h"
> #include "box/tuple.h"
> +#include "box/port.h"
> #include "sqlInt.h"
> #include "vdbeInt.h"
> #include "tarantoolInt.h"
> @@ -1783,6 +1784,48 @@ case OP_BuiltinFunction: {
> 	break;
> }
> 
> +/* Opcode: Function P1 P2 P3 P4 P5

Nit: P1 is unused. As a rule we spot unused arguments with stars (*).
And I’d swap P1 and P5, i.e. pass range of registers in P1-P2,
save result to P3

The rest now seems to be OK.