[tarantool-patches] Re: [PATCH 0/3] Merge struct sql_txn into struct txn/savepoint

[Konstantin Osipov]

* Nikita Pettik <korablev at tarantool.org> [19/08/07 18:19]:
> Branch: https://github.com/tarantool/tarantool/tree/np/move-sql-structs-from-txn
> 
> As a one of final steps of merging SQL and NoSQL codebases, it is
> required to squash struct sql_txn and struct txn/struct txn_savepoint.
> struct sql_txn was needed to operate on named savepoints. Hence, it
> contains name of savepoint and a link to next savepoint. This patch-set
> adds optional name of savepoint to struct txn_savepoint and orginizes
> txn_savepoints into list. Head of list is held in stuct txn. Iterating
> over list allows to find savepoint by its name. Finally, after this
> procedure is completed, we can remove struct sql_txn and struct Savepoint.

Thanks for the patch, overall LGTM (but I did not look carefully).

-- 
Konstantin Osipov, Moscow, Russia