[tarantool-patches] Re: [PATCH] build: fix linking with static openssl library

[Alexander Turenko]

On Sun, Aug 25, 2019 at 02:15:38PM +0300, Alexander Turenko wrote:
> > > Before this patch we add Z library to OPENSSL_LIBRARIES when
> > > BUILD_STATIC is enabled. It is not quite correct: we should do that when
> > > OPENSSL_USE_STATIC_LIBS is enabled. However we didn't experienced
> > > problems with static linking of libcurl (when BUILD_STATIC is enabled),
> > > because OPENSSL_LIBRARIES is added to CURL_LIBRARIES. This is a kind of
> > > side effect of dependency libcurl on OpenSSL and it is better to add
> > > libz explicitly to CURL_LIBRARIES (and OPENSSL_LIBRARIES) when
> > > appropriate.
> > 
> > Is it correct, that all the curl-related changes are just sugar not
> > related to the bug? Because I spent some time on attempts to understand,
> > how is curl related to the problem, but looks like in no way.
> 
> It is a kind of refactoring, yep. I had understood the problem better
> and so wrote better code to fix it. I would start the paragraph with a
> remark like:
> 
> > The patch contains changes around linking with libcurl: they does not
> > change any behaviour. Consider them as refactoring.
> 
> Then I'll describe why it is changed, why it did work before and so:
> just like in the current paragraph.
> 
> I'll let you know when will update the branch.
> 
> WBR, Alexander Turenko.

I removed the paragraph of the question and added the following one:

 | The patch changes OPENSSL_LIBRARIES variable to fix the issue with
 | static linking of OpenSSL libraries. It also changes CURL_LIBRARIES in
 | the same way, however this does not alter any visible behaviour, because
 | OPENSSL_LIBRARIES is added to CURL_LIBRARIES. The latter change was made
 | to unify the way to choose libraries to link with: it is pure
 | refactoring part.

Hope it clarifies why I touched FindCURL.cmake.

Rebased the branch on top of the current master.

branch: Totktonada/gh-4437-fix-static-openssl-build-full-ci

WBR, Alexander Turenko.