[tarantool-patches] Re: [PATCH 7/8] netbox: allow passing options to :execute()

[Vladislav Shpilevoy]

Thanks for the patch!

On 27/08/2019 15:34, Nikita Pettik wrote:
> To implement dry-run execution, let's allow 'options' be valid argument
> of :execute() method. SQL options are encoded with IPROTO_OPTIONS
> request key. Options are supposed to be a map of named parameters or a
> list of unnamed (considering their order). The only currently available
> option is 'dry_run' with boolean values. Now it doesn't affect anything,
> but will allow to get meta-information of query execution.

Why do you need an array of unnamed options? Such thing will be impossible
to maintain. Each time you will add a new option, you will extend this array,
and to pass that option a user would need to pass all the previous ones.
Please, drop arrays support.