[tarantool-patches] [PATCH 1/2] Do not log error in engine_find()

Nikita Pettik korablev at tarantool.org
Mon Aug 19 17:49:33 MSK 2019


Error logging in engine_find() seems to be redundant: error message is
displayed twice (since its callers always push error on the top).  Let's
remove this duplication.
---
 src/box/engine.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/box/engine.h b/src/box/engine.h
index a302b3bca..ef694da00 100644
--- a/src/box/engine.h
+++ b/src/box/engine.h
@@ -235,10 +235,8 @@ static inline struct engine *
 engine_find(const char *name)
 {
 	struct engine *engine = engine_by_name(name);
-	if (engine == NULL) {
+	if (engine == NULL)
 		diag_set(ClientError, ER_NO_SUCH_ENGINE, name);
-		diag_log();
-	}
 	return engine;
 }
 
-- 
2.15.1





More information about the Tarantool-patches mailing list