[tarantool-patches] Re: [PATCH v2 2/7] vinyl: don't exempt dropped indexes from dump and compaction

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/08/20 11:15]:
> > Why did you add a trigger - to avoid dependency
> > loops between vy_lsm and vy_scheduler? But sounds like it's
> > simpler to make vy_lsm aware in vy_scheduler and register/unregister
> > itself in create/destroy. Why did you choose to add a trigger
> > instead?
> 
> To avoid a dependency loop: vy_scheduler.[hc] depends on vy_lsm.[hc],
> but not vice versa, which is nice IMO.
> 
> Besides, I think we could reuse the trigger for other purposes, e.g. to
> force data file deletion when an index is finally released.

OK. The dependency loop is still there, it's just less explicit.
But let it be, it's not a big deal.
-- 
Konstantin Osipov, Moscow, Russia