[tarantool-patches] Re: [PATCH v1] gitlab-ci: add static build

Alexander Turenko alexander.turenko at tarantool.org
Fri Aug 16 05:30:09 MSK 2019


I looked briefly and it seems to be okay. But, please, remove cleanup
changes from the dockerfile: they hide real changes and bloats the
patch.

I'll look deeper when you'll update the patch.

WBR, Alexander Turenko.

> -RUN set -x \
> -    && yum -y install \
> +RUN set -x && \
> +    yum -y install \

I meant this kind of changes.

> -RUN yum -y install ncurses-static readline-static zlib-static pcre-static glibc-static
> +    yum -y install \
> +        ncurses-static \
> +        readline-static \
> +        zlib-static \
> +        pcre-static \
> +        glibc-static && \
> +    yum -y install \
> +        python-devel \
> +        python-pip

This.

> +WORKDIR /
>  
>  RUN set -x && \
> -    cd / && \
>      curl -O -L https://www.openssl.org/source/openssl-1.1.0h.tar.gz && \
>      tar -xvf openssl-1.1.0h.tar.gz && \
>      cd openssl-1.1.0h && \

And this.




More information about the Tarantool-patches mailing list