[tarantool-patches] Re: [PATCH v2 2/3] box: rename diag_add_error to diag_set_error

Konstantin Osipov kostja at tarantool.org
Tue Aug 27 01:27:50 MSK 2019


* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/08/23 13:03]:
> Renamed function diag_add_error to diag_set_error because it
> actually replaces an error object in diagnostic area with a new
> one and this name is not representative. Moreover, we are going
> to introduce a new diag_add_error that extends error object in
> diagnostic area in following patches.

lgtm, it's obvious.

-- 
Konstantin Osipov, Moscow, Russia




More information about the Tarantool-patches mailing list