[tarantool-patches] Re: [PATCH v1] Set fragile option to flaky tests

Alexander Turenko alexander.turenko at tarantool.org
Thu Aug 29 04:07:16 MSK 2019


I don't have objections here. CCed Kirill.

Does it actually makes CI more stable (for our and Travis-CI
infrastructure)? Just curious.

WBR, Alexander Turenko.

> diff --git a/test/vinyl/suite.ini b/test/vinyl/suite.ini
> index 54e6618d6..c8bc270f3 100644
> --- a/test/vinyl/suite.ini
> +++ b/test/vinyl/suite.ini
> @@ -12,3 +12,6 @@ is_parallel = True
>  # throttle.test.lua temporary disabled for gh-4168
>  disabled = upgrade.test.lua throttle.test.lua
>  pretest_clean = True
> +fragile = errinj.test.lua             ; gh-4346
> +          select_consistency.test.lua ; gh-4385
> +          throttle.test.lua           ; gh-4168
> diff --git a/test/wal_off/suite.ini b/test/wal_off/suite.ini
> index 637678c26..ed77be157 100644
> --- a/test/wal_off/suite.ini
> +++ b/test/wal_off/suite.ini
> @@ -7,3 +7,4 @@ use_unix_sockets_iproto = True
>  is_parallel = True
>  pretest_clean = True
>  disabled = iterator_lt_gt.test.lua
> +fragile = iterator_lt_gt.test.lua ; gh-3925

The test is disabled at all, should it be in fragile list too?

The same question for throttle.test.lua above (maybe other tests too, I
didn't verify it precisely).

It does not matter for me, I just observed it and point, because it may
be unintentional.

You can, say, add issue numbers to 'disabled' values: I don't mind.




More information about the Tarantool-patches mailing list