[tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS

[Konstantin Osipov]

* Maxim Melentiev <m.melentiev at corp.mail.ru> [19/08/20 18:29]:
> It's quite  complicated now: cmake WITH_SYSTEMD flag is also used to
> generate systemd units, tarantool-generator and other systemd related files.
> 
> I think that support for NOTIFY_SOCKET should not be systemd-related, as
> it's enabled in runtime by envar and is disabled otherwise.

Then add WITH_NOITFY_SOCKET as a separate option. WITH_SYSTEMD
could imply it.

> On 19/08/2019 23:18, Konstantin Osipov wrote:
> > > -#if defined(WITH_SYSTEMD)
> > I don't think you should remove this ifdef at all. Simply enable
> > it on Mac OSX by default in cmake if it works there now.

-- 
Konstantin Osipov, Moscow, Russia