[tarantool-patches] Re: [PATCH v2 2/8] sql: GREATEST, LEAST instead of MIN/MAX overload

Kirill Shcherbatov kshcherbatov at tarantool.org
Tue Aug 13 11:26:06 MSK 2019


> So, basically this patch does two things: renames existing
> scalar min/max funcs and reserves names for them in NoSQL
> cache. Please, explicitly outline these facts in commit message.
> Also, I guess name change should be documented.
Fixed. 

> 
>> Moreover it is an important stem to get rid of function's name
> 
> Nit: stem -> step.
FIxed.

> Does this patch come in scope of 2.2.2?
> I thought that it will be part of 2.3.1 (at least
> issues to be closed are related to 2.3).
> 
> The rest is OK.
Fixed.




More information about the Tarantool-patches mailing list