[tarantool-patches] Re: [PATCH v2 2/8] sql: GREATEST, LEAST instead of MIN/MAX overload

[n.pettik]

> On 8 Aug 2019, at 17:50, Kirill Shcherbatov <kshcherbatov at tarantool.org> wrote:
> 
> The MIN/MAX functions are typically used only as aggregate
> functions in other RDBMS(MSSQL, Postgress, MySQL, Oracle) while
> Tarantool's SQLite legacy code use them also in meaning
> GREATEST/LEAST scalar function. This must be fixed.

So, basically this patch does two things: renames existing
scalar min/max funcs and reserves names for them in NoSQL
cache. Please, explicitly outline these facts in commit message.
Also, I guess name change should be documented.

> Moreover it is an important stem to get rid of function's name

Nit: stem -> step.

> overloading required for replace FuncDef cache with Tarantool's
> function cache.
> diff --git a/src/box/lua/upgrade.lua b/src/box/lua/upgrade.lua
> index 046eb3ee4..73b39332e 100644
> --- a/src/box/lua/upgrade.lua
> +++ b/src/box/lua/upgrade.lua
> @@ -910,6 +910,25 @@ local function upgrade_to_2_2_1()
>     create_func_index()
> end
> 
> +--------------------------------------------------------------------------------
> +-- Tarantool 2.2.2
> +--------------------------------------------------------------------------------
> +
> +local function upgrade_to_2_2_2()

Does this patch come in scope of 2.2.2?
I thought that it will be part of 2.3.1 (at least
issues to be closed are related to 2.3).

The rest is OK.