[tarantool-patches] Re: [PATCH] tarantoolctl doesn't fail when box.cfg is delayed in init script
Kirill Yukhin
kyukhin at tarantool.org
Thu Aug 22 16:06:19 MSK 2019
Hello,
On 21 Aug 02:15, Alexander Turenko wrote:
> On Tue, Aug 20, 2019 at 02:24:23PM +0300, Maxim Melentiev wrote:
> > > BTW, is this is enough for you in the scope of your task or we need to
> > > boost other tarantoolctl discussions very soon?
> > This should be enough to complete our task (with some limitations).
> >
> > However we decided not to proceed with patching tarantoolctl right now
> > and provide start/stop features in rock’s binary replacing ctl for cluster apps.
> > Thank you for review. Please, ignore this patch request.
>
> The patch looks good for me as well. Thanks!
>
> I think that it is valuable even if your team does not needed it right
> now.
>
> CCed Kirill to decide about branches to which it should land.
>
> Max, I guess a mainainer may ask you to provide a branch in
> tarantool/tarantool repository with your commit at top of current
> master.
>
> Kirill, the patch has LGTMs from Kostya O. and me.
Checked into 2.2 and master.
--
Regards, Kirill Yukhin
More information about the Tarantool-patches
mailing list