[tarantool-patches] Re: [PATCH] build: fix linking with static openssl library

[Alexander Turenko]

> > Before this patch we add Z library to OPENSSL_LIBRARIES when
> > BUILD_STATIC is enabled. It is not quite correct: we should do that when
> > OPENSSL_USE_STATIC_LIBS is enabled. However we didn't experienced
> > problems with static linking of libcurl (when BUILD_STATIC is enabled),
> > because OPENSSL_LIBRARIES is added to CURL_LIBRARIES. This is a kind of
> > side effect of dependency libcurl on OpenSSL and it is better to add
> > libz explicitly to CURL_LIBRARIES (and OPENSSL_LIBRARIES) when
> > appropriate.
> 
> Is it correct, that all the curl-related changes are just sugar not
> related to the bug? Because I spent some time on attempts to understand,
> how is curl related to the problem, but looks like in no way.

It is a kind of refactoring, yep. I had understood the problem better
and so wrote better code to fix it. I would start the paragraph with a
remark like:

> The patch contains changes around linking with libcurl: they does not
> change any behaviour. Consider them as refactoring.

Then I'll describe why it is changed, why it did work before and so:
just like in the current paragraph.

I'll let you know when will update the branch.

WBR, Alexander Turenko.