[tarantool-patches] Re: [PATCH 6/8] refactoring: use sql_prepare() and sql_execute() in tx_process_sql()

[Vladislav Shpilevoy]

Thanks for the patch!

I think, it is better to keep using subsystem names in commit
titles. I.e. not 'refactoring:', but 'sql:'.

On 27/08/2019 15:34, Nikita Pettik wrote:
> In case of dry-run execution we don't need to substitute binding values
> or execute statement. So now we split sql_prepare_and_execute() into
> independent steps, so that we can omit some of them depending on
> execution mode.

Not sure if it is worth doing. I think, you can keep prepare_and_execute,
pass sql_opts to it, and inside this function you fill port options, omit
execution etc. Anyway you will end up with the same, but in two places -
Lua and iproto. It is better to have one function for both.