[tarantool-patches] Re: [PATCH v4 3/5] sql: remove name overloading for SQL builtins

[Nikita Pettik]

On Fri, Aug 23, 2019 at 06:02:12PM +0300, Kirill Shcherbatov wrote:
> Now all SQL builtins are unique, i.e. each function has the only
> hash table entry. This technique requires to remove static argc
> checks for some builtins(substr, round, like, trim, count,
> group_concat). Now they raise a runtime error in case of invalid
> usage.

LGTM.

PS Note that I've sent patch which fixes an assertion fault connected
with wrong number of arguments passed to GREATEST/LEAST functions:
https://www.freelists.org/post/tarantool-patches/PATCH-sql-make-GREATESTLEAST-builtins-accept-at-least-two-args

You can cherry-pick it on your branch, in case it doesn't get
to the master earlier.