[tarantool-patches] Re: [PATCH v1] test: use unix sockets iproto

[Alexander Turenko]

Hi!

Please, do self-review before send a patch. I'm sure you would ask the
same questions that I asked below and either fix them or describe
reasons in the commit message.

WBR, Alexander Turenko.

On Thu, Apr 04, 2019 at 11:49:50AM +0300, avtikhon wrote:
> Set to use unix sockets iproto instead of TCP sockets.

A reason? Yep, I know, it is avoiding 'Address already in use' errors.
And I know that it is because port checking in test-run is not
sufficient and races are possible. But a reader of your commit unlikely
have enough context.

It worth to add a link to related test-run issue here.

And don't forget to add fixes / closes #xxxx and the end of a commit
message.

> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4008-test-in-parallel-iproto
> Issue: https://github.com/tarantool/tarantool/issues/4008

> diff --git a/test/vinyl/replica_rejoin.lua b/test/vinyl/replica_rejoin.lua
> index 7cb7e09a4..9b95d50aa 100644
> --- a/test/vinyl/replica_rejoin.lua
> +++ b/test/vinyl/replica_rejoin.lua
> @@ -7,7 +7,7 @@ end
>  
>  box.cfg({
>      replication     = replication,
> -    vinyl_memory    = 1024 * 1024,
> +    vinyl_memory    = 107374182,
>  })

How it related to the patch?

>  require('console').listen(os.getenv('ADMIN'))
> diff --git a/test/vinyl/replica_rejoin.result b/test/vinyl/replica_rejoin.result
> index 1dfcb91b8..f590e05b2 100644
> --- a/test/vinyl/replica_rejoin.result
> +++ b/test/vinyl/replica_rejoin.result
> @@ -51,8 +51,6 @@ fio.glob(fio.pathjoin(box.space.test.id, 0, '*'))
>  ---
>  - - 9000/0/00000000000000000002.index
>    - 9000/0/00000000000000000002.run
> -  - 9000/0/00000000000000000004.index
> -  - 9000/0/00000000000000000004.run

And this.