[tarantool-patches] Re: [PATCH v2 00/15] sql: support -2^63 .. 2^64-1 integer type

n.pettik korablev at tarantool.org
Tue Apr 2 19:54:07 MSK 2019



> On 1 Apr 2019, at 23:44, Stanislav Zudin <szudin at tarantool.org> wrote:
> 
> The patch enables support of big integers in the range [2^63, 2^64-1].
> Conversion functions use return value to inform about value
> they return - signed integer in the range [-2^63,2^63-1] or 
> unsigned integer in the range [2^63, 2^64 -1].
> The changes affect sql processing, VDBE, arithmetic functions and
> aggregate functions.
> 
> The second version includes the following:
> - New tests
> - VDBE treats unsigned as a separate type.
> - Refactored mapping vdbe data types to sql types
> - Fixed bugs in the previous commits
> - The type conversion supports unsigned integers
> 
> Issue: https://github.com/tarantool/tarantool/issues/3810
> Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-3810-sql-uint64-support
> 
> Stanislav Zudin (15):
>  sql: Convert big integers from string
>  sql: make VDBE recognize big integers
>  sql: removes unused function.
>  sql: support big integers within sql binding
>  sql: removes redundant function.
>  sql: arithmetic functions support big integers
>  sql: aggregate sql functions support big int
>  sql: fixes errors
>  sql: support -2^63 .. 2^64-1 integer type
>  sql: support -2^63 .. 2^64-1 integer type
>  sql: support -2^63 .. 2^64-1 integer type
>  sql: support -2^63 .. 2^64-1 integer type
>  sql: support -2^63 .. 2^64-1 integer type
>  sql: support -2^63 .. 2^64-1 integer type
>  sql: support -2^63 .. 2^64-1 integer type

Could you please organise your patch-set? Squash review fixes,
squash tests with corresponding patches, squash similar changes
etc.

Now I simply can’t navigate through these patches…





More information about the Tarantool-patches mailing list