[tarantool-patches] Re: [PATCH v1 2/3] sql: rework diag_set() in OP_Halt

[Imeev Mergen]

Hi! Thank you for review. Next time I will send this patch as part
of "diag_set() in vdbe" patch-set.

On 4/29/19 2:35 AM, n.pettik wrote:
>
>> On 26 Apr 2019, at 10:48, Mergen Imeev <imeevma at tarantool.org> wrote:
>>
>> On Mon, Apr 15, 2019 at 06:21:55PM +0300, n.pettik wrote:
>>>
>>>> On 12 Apr 2019, at 15:34, imeevma at tarantool.org wrote:
>>>>
>>>> Before this patch it was possible to have an error code with wrong
>>>> error description. This patch fixes it.
>>> Could you please supply this statement with an example(s)?
>>>
>> I changed the commit message. In fact, I found an error that had
>> no error code at all:
> Could you fix that?
Already done in this commit.
>
>> ...
>>
>> tarantool> box.execute('select 1 limit true')
>> ---
>> - error: Only positive integers are allowed in the LIMIT clause
>> ...
>>
>> tarantool> box.error.last().code
>> ---
>> - 0
>> ...
>>
>>
>> I still think it would be better to use P3 instead of P5.
> Does it matter?
This will allow using only one statement instead of two. The error
described above was caused by the lack of the second statement.
After this patch, this case is less likely, because if there is no
second operator, an “unknown error” will be shown.