[tarantool-patches] Re: [PATCH v1 1/1] tap: fix is_deeply box.NULL corner cases

[Kirill Yukhin]

Hello,

On 23 Apr 15:55, Kirill Shcherbatov wrote:
> The tap:is_deeply call used to return inconsistent result
> processing an empty tuple and tuple that has no values:
> is_deeply({a = box.NULL}, {})  == true
> is_deeply({}, {a = box.NULL}) == false
> Fixed to return true in such case.
> 
> We shouldn't return false in such case because of marshaling
> features covered by tests:
> is_deeply(decode(encode(t)), t) must be true for all t,
> including t = nil; decode(encode(nil)) == box.NULL.
> 
> Closes #4125
> ---
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-4125-inconsistent-isdeeply-results
> Issue: https://github.com/tarantool/tarantool/issues/4125

I've checked your patch into master and 2.1 branch.

--
Regards, Kirill Yukhin