[tarantool-patches] Re: [PATCH v3 1/7] box: cleanup key_def virtual extract_key setter

[Vladimir Davydov]

On Wed, Apr 03, 2019 at 07:22:56PM +0300, Kirill Shcherbatov wrote:
> > Yeah, this looks better. However, I'd also replace set_extract_func with
> > plain if-else-if - it would take only a couple lines longer, but look
> > more straightforward IMO.
> 
> I don't mind. Updated version is on the branch.
> 
> ======================================================
> 
> This patch inspired by 082cffca4dba attempts to simplify setting
> appropriate tuple_extract_key pointer for plain and json indexes
> in key_def_set_extract_func routine.
> Being split to plain and json blocks this code becomes easier
> to understand and extend.
> 
> In further patches we need to introduce is_multikey branch and
> without this refactoring required amendments turn the
> key_def_set_extract_func code into a mess.
> 
> Needed for #1257
> ---
>  src/box/tuple_extract_key.cc | 97 +++++++++++++++++++-----------------
>  1 file changed, 52 insertions(+), 45 deletions(-)

Pushed to master.