[tarantool-patches] Re: [PATCH v2] xrow: print corrupted rows on decoding error.

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/04/04 17:57]:
> Pushed to master, 2.1, 1.10.

This was fast.

First of all, we already have request_str() function, and there is
a good deal of code reuse that can take place.

This comment, basically, says it all.

But provided you had to write your own implementation:
- why use a macro?
- why use malloc?
- what's wrong with mp_snprint, and if the problem is that it
  doesn't properly escape non-printable characters, why not fix it
  to escape these or implement a version which does?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov