[tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine

[Kirill Yukhin]

Hello,

On 17 апр 16:38, Konstantin Osipov wrote:
> * Kirill Yukhin <kyukhin at tarantool.org> [19/04/15 17:06]:
> > +/**
> > + * Create an array of key_defs from array of index definitions.
> 
> Why allocate on region? We usually allocate key_defs with
> malloc().

I didn't change this peace of code. It was always alloacted on a region.
See [1].

> 
> The function should be called index_def_to_key_def() or similar.

Done (in another mail).

--
Regards, Kirill Yukhin

[1] - https://github.com/tarantool/tarantool/blob/master/src/box/memtx_space.c#L982