[tarantool-patches] Re: [PATCH 1/1] swim: keep encoded round message cached

[Vladislav Shpilevoy]

Pushed to the master.

On 11/04/2019 19:24, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/11 19:13]:
> 
> OK to push.
> 
>>> Are you going to add anything to this method? If not, please get
>>> rid of it and inline swim_packet_create() to all relevant places,
>>> with an appropriate comment.
>>
>> I am not going to change it now, but
>>
>> 1) I (or anyone else) can change my (their) mind in future. Even
>>    during SWIM development we already did it. I have this patch
>>    since the SWIM implementation was multi-packet, and invalidation
>>    of the cache was different.
>>
>> 2) This logic of recreating the packet is too internal to be
>>    inlined in all the usage places. I would rather comment this
>>    function and logic in one encapsulated place, and would just
>>    call it.
> 
> They can easily re-introduce this function when necessary.
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
>