[tarantool-patches] Re: [PATCH v3 2/7] lib: introduce a new json_path_multikey_offset helper

Konstantin Osipov kostja at tarantool.org
Thu Apr 4 09:17:18 MSK 2019


* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/04/03 21:37]:
> > IMO returning path_len if no multikey token is found would be more
> > common (think of STL methods, which return end() iterator if not found).
> > Doesn't really matter though.
> > 
> > Other than that looks good to me.
> 
> I don't mind. Updated version is on the branch.

I agree, since "not found" is not an error, it's search result.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list