[tarantool-patches] Re: [PATCH 2/6] test: remove swim packet filter destructors

Konstantin Osipov kostja at tarantool.org
Wed Apr 24 19:37:50 MSK 2019


* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/24 18:50]:
> Swim test packet filters are supposed to filter out packets
> matching certain criteria or with a probability. They were
> implemented as a filter-function and userdata passed into the
> former on each invocation. Usually it was allocated on heap and
> needed deletion. But it appeared that much simpler is to store
> the filters inside struct swim_node, pass it as userdata, and get
> rid of userdata destructors and dynamic allocations.
> 
> The patch is motivated by necessity to add one new filter, which
> anyway will need struct swim_node as userdata.

OK to push.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list