[PATCH 01/13] vinyl: store tuple comparison hints in memory tree

Konstantin Osipov kostja.osipov at gmail.com
Thu Apr 4 12:48:09 MSK 2019


* Vladimir Davydov <vdavydov.dev at gmail.com> [19/04/04 12:12]:
> > vy_mem_tree_iterator_is_eof()
> > vy_mem_tree_eof
> > 
> > or:
> > 
> > vy_mem_tree_iterator_is_eof()
> > vy_mem_tree_null
> 
> I called it 'invalid' to be consistent with the BPS tree API, see
> bps_tree_invalid_iterator.
> 
> Also, it's used not only for EOF - we set the iterator position to
> this value before iteration is started.
> 
> That said, I'd rather leave the name as is.

I'd rename it across the board.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list