[tarantool-patches] Re: [PATCH] sql: fix extra type calculation before bytecode generation

Konstantin Osipov kostja at tarantool.org
Fri Apr 5 08:49:07 MSK 2019


* Nikita Pettik <korablev at tarantool.org> [19/04/05 06:36]:
> In SQL type of constant literal (e.g. 1, 2.5, 'abc') is assigned right
> after parsing and saving into struct Expr. Occasionally, type is
> re-assigned before emitting opcodes to store literal into VDBE memory.
> What is more, for floating point number type is changed to "integer".
> This patch fixes this obvious misbehaviour.

LGTM (for 2.1)


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list