[tarantool-patches] Re: [PATCH v1 1/1] Implement mp_stack_top for mp_stack class

[Vladimir Davydov]

On Wed, Apr 03, 2019 at 08:49:23PM +0300, Kirill Shcherbatov wrote:
> @@ -2349,6 +2337,12 @@ mp_stack_is_full(struct mp_stack *stack)
>  	return stack->used >= stack->size;
>  }
>  
> +MP_IMPL struct mp_frame *
> +mp_stack_top(struct mp_stack *stack)
> +{

Nit:
	assert(!mp_stack_is_empty(stack));

> +	return &stack->frames[stack->used - 1];
> +}

Other than that, the patch looks good, BUT for some reason it doesn't
compile on CentOS 6 on Travis, see

  https://travis-ci.org/tarantool/msgpuck/jobs/515314874

It fails with

  BFD: /build/BUILDROOT/msgpuck-2.0.23-1.el6.x86_64/usr/lib64/libmsgpuck.a(msgpuck.c.o): invalid relocation type 42

Please figure out why is that and fix if possible.