[tarantool-patches] Re: [PATCH 04/13] sql: support big integers within sql binding

Konstantin Osipov kostja at tarantool.org
Tue Apr 2 10:46:46 MSK 2019


* n.pettik <korablev at tarantool.org> [19/03/25 18:13]:
> > +
> > +		SQL_BLOB,	/* 0x20 */
> > +		SQL_NULL,	/* 0x21 */
> > +		SQL_TEXT,	/* 0x22 */
> > +		SQL_NULL,	/* 0x23 */
> > +		SQL_UNSIGNED,	/* 0x24 */
> > +		SQL_NULL,	/* 0x25 */
> > +		SQL_UNSIGNED,	/* 0x26 */
> > +		SQL_NULL,	/* 0x27 */
> > +		SQL_FLOAT,	/* 0x28 */
> > +		SQL_NULL,	/* 0x29 */
> > +		SQL_FLOAT,	/* 0x2a */
> > +		SQL_NULL,	/* 0x2b */
> > +		SQL_INTEGER,	/* 0x2c */
> > +		SQL_NULL,	/* 0x2d */
> > +		SQL_INTEGER,	/* 0x2e */
> > +		SQL_NULL,	/* 0x2f */
> > +		SQL_BLOB,	/* 0x30 */
> > +		SQL_NULL,	/* 0x31 */
> > +		SQL_TEXT,	/* 0x32 */
> > +		SQL_NULL,	/* 0x33 */
> > +		SQL_INTEGER,	/* 0x34 */
> > +		SQL_NULL,	/* 0x35 */
> > +		SQL_INTEGER,	/* 0x36 */
> > +		SQL_NULL,	/* 0x37 */
> > +		SQL_FLOAT,	/* 0x38 */
> > +		SQL_NULL,	/* 0x39 */
> > +		SQL_FLOAT,	/* 0x3a */
> > +		SQL_NULL,	/* 0x3b */
> > +		SQL_INTEGER,	/* 0x3c */
> > +		SQL_NULL,	/* 0x3d */
> > +		SQL_INTEGER,	/* 0x3e */
> > +		SQL_NULL,	/* 0x3f */
> 
> Looks terrible. Could we rework this mechanism of fetching type?
> Soon we are going to add several types more, so the size of array
> will become enormous.

I hope we can kill this array altogether as well as mem flags and
use a combination of mp_type and enum field_type wherever
possible.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list