[PATCH 04/13] vinyl: store tuple comparison hints in tx read set

Vladimir Davydov vdavydov.dev at gmail.com
Thu Apr 4 15:08:59 MSK 2019


On Thu, Apr 04, 2019 at 02:42:32PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [19/04/02 20:35]:
> > This patch incorporates tuple comparison hints into the transaction
> > read set. Now, beside a statement, each read interval also stores hints
> > of boundary statements, which are used in all comparison operations.
> > 
> > Apart from speeding up lookups, this is also needed for multikey index
> > support, because multikey indexes will reuse hints to store offsets of
> > indexed array entries.
> 
> OK to push.
> 
> > --- a/src/box/vy_read_set.h
> > +++ b/src/box/vy_read_set.h
> > @@ -39,6 +39,7 @@
> >  #define RB_COMPACT 1
> >  #include <small/rb.h>
> >  
> > +#include "key_def.h"
> 
> Isn't it better to define hint_t in tuple_compare.h to avoid extra
> includes?

Makes sense. I'll move it in v2.



More information about the Tarantool-patches mailing list