[tarantool-patches] Re: [PATCH 3/3] crypto: implement crypto codec API and AES 128 encryption

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/29 14:09]:
> I've decided that the patch is too raw and reworked it a bit.
> I force pushed my changed resent the whole patchset in a new
> thread as V2.
> 
> Main change is addition of a second encryption algorithm - None.
> It is needed because SWIM has encryption API like
> 
>     swim_set_codec(enum crypto_algo algo, const char *key);
> 
> And I need a way how to disable encryption after its enabling.
> It can be done now via
> 
>     swim_set_codec(CRYPTO_NONE, NULLL);
> 
> 
> Secondly, I renamed 'encode/decode' to 'encrypt/decrypt' in
> all methods and tests.
> 
> Thirdly, I removed hardcoded block sizes from encrypt() method.

All of the above is good stuff.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32