[tarantool-patches] Re: [PATCH 3/9] sql: use msgpack types instead of custom ones

[n.pettik]

>> diff --git a/src/box/sql/date.c b/src/box/sql/date.c
>> index 5f5272ea3..1c7a5ad2d 100644
>> --- a/src/box/sql/date.c
>> +++ b/src/box/sql/date.c
>> @@ -932,12 +932,12 @@ isDate(sql_context * context, int argc, sql_value ** argv, DateTime * p)
>> {
>> 	int i, n;
>> 	const unsigned char *z;
>> -	int eType;
>> +	enum mp_type eType;
>> 	memset(p, 0, sizeof(*p));
>> 	if (argc == 0) {
>> 		return setDateTimeToCurrent(context, p);
>> 	}
>> -	if ((eType = sql_value_type(argv[0])) == SQL_FLOAT
>> +	if ((eType = sql_value_type(argv[0])) == MP_DOUBLE
>> 	    || eType == SQL_INTEGER) {
> 
> SQL_INTEGER is removed already. Please, replace with MP_INT.

Ok, removed. This was dead code, so compiler didn’t
show any warnings/compile errors.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20190423/c466e1d5/attachment.html>