[tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Thu Apr 18 14:39:12 MSK 2019
On 18/04/2019 14:14, Kirill Yukhin wrote:
> Hello,
>
> On 18 апр 13:43, Vladislav Shpilevoy wrote:
>> Hi! Thanks for the fixes! See 4 comments below.
>>
>> 1. Now I see that sysview tuple format leaks. Please,
>> apply this diff:
>>
>> ======================================================
>> diff --git a/src/box/sysview.c b/src/box/sysview.c
>> index 0b07c9f4a..96c5e78ca 100644
>> --- a/src/box/sysview.c
>> +++ b/src/box/sysview.c
>> @@ -545,6 +545,8 @@ sysview_engine_create_space(struct engine *engine, struct space_def *def,
>> free(space);
>> return NULL;
>> }
>> + /* Format is now referenced by the space. */
>> + tuple_format_unref(format);
>> return space;
>> }
>> ======================================================
>
> Done.
>
> Branch force-pushed and re-tested.
How was it retested?
[024] Test failed! Result content mismatch:
[024] --- wal_off/alter.result Thu Apr 18 14:36:14 2019
[024] +++ wal_off/alter.reject Thu Apr 18 14:37:03 2019
[024] @@ -28,7 +28,7 @@
[024] ...
[024] #spaces;
[024] ---
[024] -- 65488
[024] +- 65505
[024] ...
[024] -- cleanup
[024] for k, v in pairs(spaces) do
[024]
Looks like some of the previously leaking formats are
back in the pool, good.
>
> --
> Regards, Kirill Yukhin
>
More information about the Tarantool-patches
mailing list