[tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute()

Konstantin Osipov kostja at tarantool.org
Tue Apr 2 11:13:53 MSK 2019


* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/01 23:03]:
> +	if (column_count > 0) {
> +		lua_createtable(L, 0, 2);
> +		lua_sql_get_description(stmt, L, column_count);
> +		lua_setfield(L, -2, "metadata");

Could we rename lua_qsl_get_description() to
lua_sql_get_metadata() to be consistent in naming?

Otherwise LGTM.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list